am 4b6756db: Merge "Remove unnecessary harmful finish() from SettingsActivity"

* commit '4b6756db3c3ab982daaf378bc9677c8a1e26ece0':
  Remove unnecessary harmful finish() from SettingsActivity
This commit is contained in:
Tadashi G. Takaoka 2013-04-15 00:35:26 -07:00 committed by Android Git Automerger
commit 1a42236a8b

View File

@ -16,7 +16,6 @@
package com.android.inputmethod.latin;
import android.app.Activity;
import android.app.backup.BackupManager;
import android.content.Context;
import android.content.Intent;
@ -115,12 +114,8 @@ public final class SettingsFragment extends InputMethodSettingsFragment
if (FeedbackUtils.isFeedbackFormSupported()) {
feedbackSettings.setOnPreferenceClickListener(new OnPreferenceClickListener() {
@Override
public boolean onPreferenceClick(Preference arg0) {
final Activity activity = getActivity();
FeedbackUtils.showFeedbackForm(activity);
if (!activity.isFinishing()) {
activity.finish();
}
public boolean onPreferenceClick(final Preference pref) {
FeedbackUtils.showFeedbackForm(getActivity());
return true;
}
});