From 719f92fc77d10a55fe78daa5bce9617d8a0af335 Mon Sep 17 00:00:00 2001 From: Jean Chalard Date: Thu, 8 Mar 2012 20:35:47 +0900 Subject: [PATCH] Stop uselessly remembering a value (A2) The value is only used in debug mode, and it can be recomputed at the time. This change does not impact the logic. There is however a side effect: in debug mode, the normalized score will be displayed also when the word comes out of the whitelist or is a valid word. It's actually a good thing. The end purpose is to make all methods in AutoCorrection static. Change-Id: I1642b1fdfa6ae62b8aa2fed94a8a26ff4a7e4d0e --- java/src/com/android/inputmethod/latin/AutoCorrection.java | 6 +++--- java/src/com/android/inputmethod/latin/Suggest.java | 6 +++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/java/src/com/android/inputmethod/latin/AutoCorrection.java b/java/src/com/android/inputmethod/latin/AutoCorrection.java index 425b5c3f3..51b51f55b 100644 --- a/java/src/com/android/inputmethod/latin/AutoCorrection.java +++ b/java/src/com/android/inputmethod/latin/AutoCorrection.java @@ -118,15 +118,15 @@ public class AutoCorrection { final int autoCorrectionSuggestionScore = sortedScores[0]; // TODO: when the normalized score of the first suggestion is nearly equals to // the normalized score of the second suggestion, behave less aggressive. - mNormalizedScore = BinaryDictionary.calcNormalizedScore( + final double normalizedScore = BinaryDictionary.calcNormalizedScore( typedWord.toString(), autoCorrectionSuggestion.toString(), autoCorrectionSuggestionScore); if (DBG) { Log.d(TAG, "Normalized " + typedWord + "," + autoCorrectionSuggestion + "," - + autoCorrectionSuggestionScore + ", " + mNormalizedScore + + autoCorrectionSuggestionScore + ", " + normalizedScore + "(" + autoCorrectionThreshold + ")"); } - if (mNormalizedScore >= autoCorrectionThreshold) { + if (normalizedScore >= autoCorrectionThreshold) { if (DBG) { Log.d(TAG, "Auto corrected by S-threshold."); } diff --git a/java/src/com/android/inputmethod/latin/Suggest.java b/java/src/com/android/inputmethod/latin/Suggest.java index 298ead665..6f2ca83a8 100644 --- a/java/src/com/android/inputmethod/latin/Suggest.java +++ b/java/src/com/android/inputmethod/latin/Suggest.java @@ -386,7 +386,11 @@ public class Suggest implements Dictionary.WordCallback { Utils.removeDupes(mSuggestions); if (DBG) { - double normalizedScore = mAutoCorrection.getNormalizedScore(); + final CharSequence autoCorrectionSuggestion = mSuggestions.get(0); + final int autoCorrectionSuggestionScore = mScores[0]; + double normalizedScore = BinaryDictionary.calcNormalizedScore( + typedWord.toString(), autoCorrectionSuggestion.toString(), + autoCorrectionSuggestionScore); ArrayList scoreInfoList = new ArrayList(); scoreInfoList.add(new SuggestedWords.SuggestedWordInfo("+", false));