From aa300bb73a970a42ffb8bc8c5419c22191a7c08a Mon Sep 17 00:00:00 2001 From: Ken Wakasa Date: Thu, 5 Apr 2012 20:45:59 +0900 Subject: [PATCH] Don't draw red underline for manually picked words that came from bigram prediction Change-Id: I544680c8b4b1baff71bd08168630a34e803c40b9 --- .../com/android/inputmethod/compat/SuggestionSpanUtils.java | 2 ++ java/src/com/android/inputmethod/latin/Suggest.java | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/java/src/com/android/inputmethod/compat/SuggestionSpanUtils.java b/java/src/com/android/inputmethod/compat/SuggestionSpanUtils.java index 5c351e41f..43c19d7eb 100644 --- a/java/src/com/android/inputmethod/compat/SuggestionSpanUtils.java +++ b/java/src/com/android/inputmethod/compat/SuggestionSpanUtils.java @@ -136,6 +136,8 @@ public class SuggestionSpanUtils { ? (OBJ_FLAG_EASY_CORRECT | OBJ_FLAG_MISSPELLED) : 0; + // TODO: We should avoid adding suggestion span candidates that came from the bigram + // prediction. final Object[] args = { context, null, suggestionsList.toArray(new String[suggestionsList.size()]), flag, (Class) SuggestionSpanPickedNotificationReceiver.class }; diff --git a/java/src/com/android/inputmethod/latin/Suggest.java b/java/src/com/android/inputmethod/latin/Suggest.java index b31f3019c..0fcac58a6 100644 --- a/java/src/com/android/inputmethod/latin/Suggest.java +++ b/java/src/com/android/inputmethod/latin/Suggest.java @@ -261,7 +261,9 @@ public class Suggest implements Dictionary.WordCallback { SuggestedWordInfo.removeDups(mSuggestions); return new SuggestedWords(mSuggestions, - false /* typedWordValid */, + // TODO: Just assuming the suggestions that came from the bigram prediction are + // valid now. Need to assign a correct value for typedWordValid. + true /* typedWordValid */, false /* hasAutoCorrectionCandidate */, false /* allowsToBeAutoCorrected */, false /* isPunctuationSuggestions */,