n/futokb
1
0
Fork 0
mirror of https://gitlab.futo.org/keyboard/latinime.git synced 2024-09-28 14:54:30 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a possible NPE in Dicttool

Browse Source 
I've never seen the NPE happen and only happened to notice
this by chance. Let's fix the code.

Change-Id: If458646229f9cadcd6c15779348133f382fde783
This commit is contained in:
Jean Chalard 2014-10-06 22:50:20 +09:00
parent 82065e36ec
commit b498d2cf84
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/dicttool/compat/android/util/Pair.java
View File

@ -17,6 +17,7 @@
package android.util;
import java.util.Arrays;
import java.util.Objects;
public class Pair<T1, T2> {
public final T1 mFirst;
@ -29,7 +30,8 @@ public class Pair<T1, T2> {
@Override
public int hashCode() {
return Arrays.hashCode(new Object[] { mFirst, mSecond });
return (mFirst == null ? 0 : mFirst.hashCode())
^ (mSecond == null ? 0 : mSecond.hashCode());
}
@Override
@ -37,7 +39,6 @@ public class Pair<T1, T2> {
if (o == this) return true;
if (!(o instanceof Pair)) return false;
Pair<?, ?> p = (Pair<?, ?>)o;
return ((mFirst == null && p.mFirst == null) || mFirst.equals(p.mFirst))
&& ((mSecond == null && p.mSecond == null) || mSecond.equals(p.mSecond));
return Objects.equals(mFirst, p.mFirst) && Objects.equals(mSecond, p.mSecond);
}
}