Commit Graph

3112 Commits

Author SHA1 Message Date
Jean Chalard
64e52051cf Simplification (B4)
Change-Id: Id5abf722a533980ed2d89381dbddc0a71b6f5b6b
2012-06-19 02:54:13 +09:00
Jean Chalard
5a1259523f Merge "Move a settings method to SettingsValues (B3)" 2012-06-18 10:53:47 -07:00
Tadashi G. Takaoka
a5bbb8df75 am e4bbff78: am 38dc9ca3: Fix duplicate period on Persian tablet keyboard
* commit 'e4bbff783bddb70f52402454987ede281fb86039':
  Fix duplicate period on Persian tablet keyboard
2012-06-18 10:52:54 -07:00
Tadashi G. Takaoka
794a9c913a am 58f9b35e: am 6de1b7a7: Fix Persian keyboard having correct code points
* commit '58f9b35e1cf5a975ec1312858aad9b5cc307fda8':
  Fix Persian keyboard having correct code points
2012-06-18 10:52:46 -07:00
Svetoslav Ganov
27bda8fee8 am 866cfd3a: am fa447071: Merge "Update LatinIME due to hidden APIs taken out of the support lib." into jb-dev
* commit '866cfd3a68c370bedc4deb3d40ff4ff7c44902bd':
  Update LatinIME due to hidden APIs taken out of the support lib.
2012-06-18 10:52:42 -07:00
Jean Chalard
fe53e5c060 Move a settings method to SettingsValues (B3)
Change-Id: Ibfa27bd919c92be219c4d107b3ace008ca80a19f
2012-06-19 02:52:36 +09:00
Tadashi G. Takaoka
38dc9ca314 Fix duplicate period on Persian tablet keyboard
Bug: 6679579
Change-Id: I8bccbfbdf7ea1fa1b78a5af05eb1df100f22ab0c
2012-06-18 10:33:03 -07:00
Jean Chalard
8b538807a3 Merge "Make a variable final (A2)" 2012-06-18 10:30:19 -07:00
Jean Chalard
0176faf6c0 Merge "Add a kind to the suggestion for bookkeeping (A1)" 2012-06-18 10:30:10 -07:00
Jean Chalard
1c3c0ff1c3 Merge "Cleanup, part 2 (C2)" 2012-06-18 10:29:06 -07:00
Jean Chalard
65b7bcb045 Merge "Cleanup, part 1 (C1)" 2012-06-18 10:28:58 -07:00
Svetoslav Ganov
d3cc73ada8 Removing implementation of unnecessary APIs taken out of the support lib.
1. We have hidden a framework API and it was take out of the
   support lib. This API is not necessary and this patch removes
   the implementation in LatinIME.

bug:6675330

Change-Id: I18aff7a6c7bc2b76c7332abe0bf294fbbb99ccfc
2012-06-17 15:22:02 -07:00
Kurt Partridge
6080f6878b Remove non-dictionary words and digit touch data.
Output to the ResearchLogger is now queued and only flushed if the word
the user was working on is a dictionary word.

multi-project commit with Ic713ec00777fbdcf4a937b3c77b995257e100fc7

Bug: 6188932
Change-Id: I9de15227ff51be23083d9096f1c1b3d83802fff7
2012-06-17 15:02:15 -07:00
Kurt Partridge
4b91046759 Merge "Replace digits in ResearchLogger" 2012-06-16 20:48:25 -07:00
Tadashi G. Takaoka
6de1b7a709 Fix Persian keyboard having correct code points
Bug: 6679850
Change-Id: Iaa33f48ffb5634de31e039574fb58185c6c078e8
2012-06-16 20:30:45 -07:00
Kurt Partridge
a696781c2b Replace digits in ResearchLogger
Digits may represent personally identifying information.  They are
now replaced with a non-identifying symbol.

multi-project commit with I07d1cfdc45f6086f67af45775f4ed12da1833aca

Bug: 6188932

Change-Id: Ifda8079e6c1f29b5f8af34c6d1fccf5770f164ca
2012-06-16 12:37:50 -07:00
Jean Chalard
c5f1d998c2 Cleanup, part 6 (C6)
Change-Id: I184f3a336278559df255c5d600a98fbba468a243
2012-06-16 10:52:49 +09:00
Jean Chalard
9b233ecef2 Cleanup, part 4 (C4)
Change-Id: I2821ae71ec49e4b6b512157d17b80198f74321e4
2012-06-16 10:51:04 +09:00
Jean Chalard
5475e92b3f Cleanup, part 3 (C3)
Change-Id: Ib0be8dc26b6fa366a3dabeea940d466602073244
2012-06-16 10:46:18 +09:00
Jean Chalard
71dc280426 Cleanup, part 2 (C2)
Change-Id: I860f41807e9bc2e38b6ad84e1527fc8707a9aa40
2012-06-16 10:40:16 +09:00
Jean Chalard
6883153dd0 Cleanup, part 1 (C1)
Change-Id: I2b1ddd836aaf6bfc0bd2befb78f98239ffcdbb22
2012-06-16 10:38:57 +09:00
Jean Chalard
4a5cb5c36a Update an outdated comment
Change-Id: I3d02dc8597ed14d998caeaa056813353e2d7ec1a
2012-06-16 10:34:57 +09:00
Jean Chalard
dca729fddd Move final attributes to SettingsValues (B2)
Bug: 6675475
Bug: 6677394
Change-Id: I4a26efb9226d3f909f331c4d2e47cd83a05c011e
2012-06-16 08:01:09 +09:00
Svetoslav Ganov
fa447071df Merge "Update LatinIME due to hidden APIs taken out of the support lib." into jb-dev 2012-06-15 15:00:55 -07:00
Jean Chalard
3d44f489b3 Inline a method for simplicity (B1)
This has a confusing name and is a one-liner

Change-Id: I954a648a8413e38a535c2b81e4b171e1bdc9f1c2
2012-06-16 03:18:00 +09:00
Jean Chalard
0998c48ac3 Make a variable final (A2)
This is never changed, and probably doesn't need to be.
It's public because it's going to be used elsewhere in a future
change

Change-Id: Iec8d65859c470de5e1fb0b05533356fbc3b8e91b
2012-06-16 03:10:54 +09:00
Jean Chalard
e7d2ee3ec3 Add a kind to the suggestion for bookkeeping (A1)
This will help for debug as well as serve as groundwork for
Bug: 6252660
Bug: 6166228
Bug: 2704000
Bug: 6225530

Change-Id: I74d0a7b943fb22c514ad79dc064d69ddf336d3ef
2012-06-16 03:10:36 +09:00
Svetoslav Ganov
b910b18c2c Update LatinIME due to hidden APIs taken out of the support lib.
1. We have hidden the APIs for accessiiblity focus search since
   it wull be perfomred by the client, updated the support lib,
   and now we are updating the LatinIME.

bug:6675330

Change-Id: I9dd3450b40148be7ce750f6bffc0a047a541982f
2012-06-15 11:01:15 -07:00
Kurt Partridge
23cec44376 Merge "No logging of passwords." 2012-06-14 21:09:20 -07:00
Tadashi G. Takaoka
9328e0f2d9 am aee2ed1f: am 14bc2e89: Fix Arabic diacritics order
* commit 'aee2ed1f4b0be7a538cc5722fed274632f2a40ba':
  Fix Arabic diacritics order
2012-06-14 21:08:18 -07:00
Tadashi G. Takaoka
14bc2e89ef Fix Arabic diacritics order
Bug: 6662536
Change-Id: I96e45ce0e8b9b5440a54f3b321a925bc87ec3ca9
2012-06-14 20:33:52 -07:00
Tadashi G. Takaoka
dfcf7cac5e am 1ab436c1: am 0e473e9c: Reorder Persian diacritics
* commit '1ab436c1e60c0e49333549fb93e135fa99458bda':
  Reorder Persian diacritics
2012-06-14 18:30:52 -07:00
Jean Chalard
a19c5e6380 resolved conflicts for merge of be82f297 to master
Change-Id: If49ca384ea0ac415a75f8ea1bad77dc6719cb04d
2012-06-15 09:03:52 +09:00
Tadashi G. Takaoka
0e473e9c92 Reorder Persian diacritics
Bug: 6661783
Change-Id: I42bab7655121ec5671854d54c47bd0c7a29e7a98
2012-06-14 16:56:36 -07:00
Kurt Partridge
1cef91e481 No logging of passwords.
Bug: 6188932
Change-Id: Ibf60ec99c50da3675bf89858624218e6cc3eb1d2
2012-06-14 15:14:20 -07:00
Jean Chalard
cf6e923b18 am 42ecf39d: am 002e43ea: Merge "Remove irrelevant options." into jb-dev
* commit '42ecf39d04df9eb02e57cf29e63552bc04092857':
  Remove irrelevant options.
2012-06-14 14:51:37 -07:00
Tadashi G. Takaoka
775d8dcaeb am de1d88eb: am 32f4ceb2: Dismiss more suggestions panel when suggestions strip is closed
* commit 'de1d88eb4199160899d227f2c679215e16410c42':
  Dismiss more suggestions panel when suggestions strip is closed
2012-06-14 14:49:08 -07:00
Jean Chalard
7cbd0478cf Merge "Do not display punctuation suggestions when bigrams are on." into jb-dev 2012-06-14 14:37:13 -07:00
Jean Chalard
002e43ead0 Merge "Remove irrelevant options." into jb-dev 2012-06-14 14:36:26 -07:00
Jean Chalard
d5b765b3bb Do not display punctuation suggestions when bigrams are on.
Bug: 6310401
Change-Id: I9d31c48e287aceedaf2f4c5129031ddb31402451
2012-06-15 06:01:09 +09:00
Jean Chalard
78573f2e8a Fix an NPE
This code is temporary until we get rid of this member.

Bug: 6662963
Bug: 6667091
Change-Id: I1d970d2a97992507e86c5b94978a2543fe42b375
2012-06-15 05:47:35 +09:00
Jean Chalard
15121cff37 Remove irrelevant options.
Bug: 6667355
Change-Id: I39b6db17fb52e80f510cf6462f41d9cb1f8e0341
2012-06-15 05:04:14 +09:00
Tadashi G. Takaoka
32f4ceb243 Dismiss more suggestions panel when suggestions strip is closed
This change fixes possible NPE as well.

Bug: 6658028
Change-Id: I8706808d1002b7b0b95930fd9b08568f08645da6
2012-06-14 11:57:43 -07:00
Satoshi Kataoka
d2f210dbe2 am d9c702d2: am 5caaf1b9: Merge "Do not add profanity to user history bigram dicitonary" into jb-dev
* commit 'd9c702d2ff017452f0264f2be12b6bffd6204e4a':
  Do not add profanity to user history bigram dicitonary
2012-06-14 10:33:47 -07:00
Tadashi G. Takaoka
c380959f48 am bbf18807: am 1db4f951: Fix the order of Persian diacritics
* commit 'bbf188075d5e14626c0609f4c3ee6031f6c6d5a6':
  Fix the order of Persian diacritics
2012-06-14 10:33:46 -07:00
Satoshi Kataoka
5caaf1b9e9 Merge "Do not add profanity to user history bigram dicitonary" into jb-dev 2012-06-14 00:31:55 -07:00
Tadashi G. Takaoka
1db4f95105 Fix the order of Persian diacritics
The java source file KeyboardTextsSet.java has rather big change, but
this file is auto generated by "maketext" tool. The crucial part of
this change is in 5 XML resource files.

Bug: 6661783
Change-Id: I1d827ab0ebe6caa5ab73531682d6c32540b0d7aa
2012-06-14 15:18:25 +09:00
Satoshi Kataoka
68c650fb2a Do not add profanity to user history bigram dicitonary
Change-Id: I864c4206e3e6cde4d6ed687a9759e98901e16b9a
2012-06-14 15:15:08 +09:00
Jean Chalard
bbd7434229 Merge "Fix an occurrence of nested batch edits." 2012-06-13 10:37:12 -07:00
Tadashi G. Takaoka
8fa20d6a36 Merge "Remove useless copy constructor of ProximityInfo" 2012-06-12 16:24:39 -07:00
Tadashi G. Takaoka
9f42140ae2 Remove useless copy constructor of ProximityInfo
Change-Id: I56b4a99f670ad38708ad83d76b93a631295e3333
2012-06-12 15:13:07 -07:00
Jean Chalard
9d71748ba4 Fix an occurrence of nested batch edits.
This is harmless, but against policy.
Also, rework the checking code to be more readable, give more
information, and be called for all relevant methods - and not
for informative methods, which are not required to be in a
batch edit.

Change-Id: I03fa8b2e7d68a6a133f86be8a214671750c29256
2012-06-13 07:02:07 +09:00
Jean Chalard
c7564a787e Optimization
This is much faster. It doesn't create messages, it doesn't post
stuff in a queue, it doesn't delay execution of other messages.
Also, it decouples the timer from the functionality of the Handler
so this can be pulled up in another change to consolidate with
mLastKeyTime or so.

Change-Id: I9044fc031373e66b9b40eee8025633613d0945dc
2012-06-13 07:02:07 +09:00
Jean Chalard
72b358aa90 Small optimization.
This will avoid some two-way IPC calls.

Change-Id: If9eb3e99b3d08346aadd4bbed2a1761f8c2527b9
2012-06-13 07:02:07 +09:00
Satoshi Kataoka
84bb18f4c9 resolved conflicts for merge of ee78e780 to master
Change-Id: I88a4996bdd17c5378a67781d8075eff311670c3b
2012-06-13 06:45:38 +09:00
Jean Chalard
58d9e46ce0 Merge "Consolidate a test." 2012-06-12 11:50:36 -07:00
Kurt Partridge
5e50eec570 Merge "Check inputs to ResearchLogger" 2012-06-12 11:39:11 -07:00
Jean Chalard
e86054e5c2 Consolidate a test.
Stop using the numerical value, use the actual method

Change-Id: Iffa7f2d21a0471c7862afd3234cc9c5dd86feb2e
2012-06-13 03:34:58 +09:00
Kurt Partridge
65fc909e13 Check inputs to ResearchLogger
to avoid NPEs.

Bug: 6188932
Change-Id: I377ceaac867df879dc7984dae44e96b369858cca
2012-06-12 10:56:03 -07:00
Jean Chalard
140adf204b Consolidate auto-correction settings.
For some reason, there were several ways, not exactly identical,
to get this setting. The ones that used mAutoCorrectionEnabled
would kick in when the input field was specifying no correction,
so it would be a little strange (although harmless in the practice
because the settings set in this way would not get used later,
because the correct test would be done at that time).

Also perform a very small refactoring

Change-Id: Ica9f32b238d98009ae1852d3c1e940398f5d341c
2012-06-12 10:29:55 +09:00
Jean Chalard
2010aad741 Move two methods in a more appropriate place
Change-Id: I512b04e23490413a44b1ca0517102fe2d9138df3
2012-06-12 10:29:55 +09:00
Jean Chalard
a32eb27213 Move an editing method to the RichInputConnection
Change-Id: Ie143ad008ca8deb1c5034cb80ec1cb28a6b0682d
2012-06-12 10:29:55 +09:00
Jean Chalard
243e370fcb Move a member call out of the way
Change-Id: I5da48442c0b39aaff817c3b6d067a9b13fda0643
2012-06-12 10:29:55 +09:00
Jean Chalard
747cf0435a Move two editing utility methods to RichInputConnection
Change-Id: If8d03bea1b6369cb3043da6321048d052995d664
2012-06-12 10:29:55 +09:00
Jean Chalard
70a046f8ca Merge "Rename mSettingsValues to mCurrentSettings" 2012-06-11 18:24:45 -07:00
Jean Chalard
64913d72bc Merge "Move suggestion strip visibility to SettingsValues" 2012-06-11 18:18:50 -07:00
Jean Chalard
15c0090e88 Merge "Accept a null input attributes for reading settings." 2012-06-11 18:18:43 -07:00
Jean Chalard
f4bc441256 Merge "Move the correction mode to SettingsValue and make it final" 2012-06-11 18:18:03 -07:00
satok
6a71f0610c Fix UserHistoryBigram data contention in UserHistoryDictionary
Bug: 6637614
Change-Id: I34d26563e59d3b09bf35b8173dac5645ccb6a39f
2012-06-12 08:00:14 +09:00
Jean Chalard
411a98afb9 Merge "Consolidate updateCorrectionMode() calls" 2012-06-11 14:02:15 -07:00
Jean Chalard
297e6d590b Rename mSettingsValues to mCurrentSettings
...for readability. After all, it makes sense that "current settings"
is a "SettingsValues", while it's harder to understand why we'd
manipulate an object named "SettingsValues".

Change-Id: Ide9a17b970a6cc00b80b9a217f986268c739c662
2012-06-08 21:34:07 +09:00
Jean Chalard
d273697259 Move suggestion strip visibility to SettingsValues
Change-Id: If34112c69acd5122d87554043d87d8f4dbdf5d15
2012-06-08 21:26:25 +09:00
Jean Chalard
01e3b014bb Accept a null input attributes for reading settings.
Change-Id: I11a8e1aca3541c35d2b39b27716687fcd8ff3dc6
2012-06-08 21:15:33 +09:00
Jean Chalard
4b9e6ee6fb Move the correction mode to SettingsValue and make it final
At last this guy is final, at last

Change-Id: I76911f8d47493f8a1719f75fc7e949be5d7da1a2
2012-06-08 21:10:35 +09:00
Jean Chalard
3791183076 Consolidate updateCorrectionMode() calls
Change-Id: I43c0505e9a1652bfc568f23b787fc68a5c5e9220
2012-06-08 21:02:19 +09:00
Ken Wakasa
e7b34b9f86 Add NativeUtils.powf()
Change-Id: I0339f39d49bc6390d098017f32d92c776974e03e
2012-06-08 20:46:19 +09:00
Jean Chalard
bbbdab12be Move some editing methods to RichInputConnection.
Change-Id: I8527776a4bd8236a85bb77f9791f9b76977ad181
2012-06-08 20:23:13 +09:00
Jean Chalard
e091982868 Straighten batch edits, pass 1
Change-Id: I73acfee9098a87b9cde8aca720586ec748b2a82f
2012-06-08 20:09:41 +09:00
Jean Chalard
02308bec63 Merge RichInputConnection with EditingUtils
Change-Id: I9982ff325bef56694402caef28a77683c52ccd71
2012-06-08 20:04:09 +09:00
Jean Chalard
5475b38328 Make a wrapper for the input connection.
The goal is to simplify the code in LatinIME.java as well as having
a handy place to put debug calls to see interaction with TextView.

Change-Id: I255227e7e7343e0c2f3dcd1f185e5020d6186732
2012-06-08 19:50:12 +09:00
Jean Chalard
c33a5428be Merge "Small performance tweak" 2012-06-08 01:22:31 -07:00
Jean Chalard
67fd0c240d Remove deprecated classes.
Should we maybe rename back *BinaryDict* to *Dict* in another
change for simplicity?

Change-Id: I8f7dcb78b9bdf1a13ce403a997fbb8619f2b453b
2012-06-08 17:12:15 +09:00
Jean Chalard
d10c473347 Small performance tweak
Change-Id: Icd540742073d49d12e70b2d8bd99aaf7ccb5802d
2012-06-08 17:09:40 +09:00
Jean Chalard
e91f32d8c1 Merge "Remove a slew of Eclipse warnings." 2012-06-08 00:35:05 -07:00
Jean Chalard
7214617622 Remove a slew of Eclipse warnings.
Change-Id: I03236386aea13fbd4fb8eaeee18e0008aa136502
2012-06-08 16:23:18 +09:00
Satoshi Kataoka
eed2cf287d Merge "Separate state from proximity_info step1" 2012-06-07 22:18:11 -07:00
Ken Wakasa
d418580a71 Fix typo
Change-Id: I264f829c1584a37995dbc5ee4ba6b6783d5d4834
2012-06-08 03:42:02 +09:00
Tadashi G. Takaoka
6b8a70105f am e4da18e2: am 6348c54f: Merge "Initializing member variable before it is referenced" into jb-dev
* commit 'e4da18e27916f770fcd704032d30534d287d67c6':
  Initializing member variable before it is referenced
2012-06-07 11:32:50 -07:00
satok
1e96cc1f51 am 674c51a0: am ec2981a4: Fix a bug on upgrading user history scheme
* commit '674c51a01117b73dd25473195f92fb0c0158da26':
  Fix a bug on upgrading user history scheme
2012-06-07 11:28:41 -07:00
Tadashi G. Takaoka
6348c54ffd Merge "Initializing member variable before it is referenced" into jb-dev 2012-06-07 11:27:32 -07:00
Tadashi G. Takaoka
40582ab438 Initializing member variable before it is referenced
Bug: 6584882
Change-Id: I1f76388fa8cc16171bc3fc60c935ddcf0a7c4e92
2012-06-07 11:17:59 -07:00
satok
ec2981a487 Fix a bug on upgrading user history scheme
Bug: 6626700
Change-Id: I3190d7404e45e704be79ee2031e79b18475feb8c
2012-06-08 02:55:23 +09:00
Tom Ouyang
11dc22d964 Merge "Contacts binary dictionary updates with change in keyboard locale." 2012-06-07 01:19:44 -07:00
Tom Ouyang
2e8aa06002 Contacts binary dictionary updates with change in keyboard locale.
Bug: 6616436
Change-Id: I8d66a37f295134c5b9875b2a305a9be7442bd75d
2012-06-07 00:25:41 -07:00
Jean Chalard
c8a120f970 am eead5492: am 769cecf7: Close spell-checking dictionaries in a background thread
* commit 'eead5492615f0b05ef85ca1f88d3a41ce3f8d496':
  Close spell-checking dictionaries in a background thread
2012-06-06 21:52:46 -07:00
Satoshi Kataoka
3e8c58f68d Separate state from proximity_info step1
Bug: 6548943

Change-Id: I7b4fbe20615a28151a74875be43b9f4a20e0dce9
2012-06-07 13:35:34 +09:00
Jean Chalard
769cecf7e7 Close spell-checking dictionaries in a background thread
Bug: 6584677
Change-Id: Ifd9b0f995f4e0cf4d35a7ecde767826ab976f0b8
2012-06-07 12:56:45 +09:00
Kurt Partridge
9b300f0caa Merge "add research log ui control" 2012-06-06 20:47:53 -07:00
Kurt Partridge
724bc479f7 add research log ui control
- lets users flag a particular time in the research log
- lets users delete the log for this session

also makes the UsabilityLog setting control whether the ResearchLog logs or not.

multi-project commit with I89067e7d3b8daca7179333f1dbe82224c26920fe

Bug: 6188932
Change-Id: I89864ef3ab53b0efe1ea8d75247be08712f0c399
2012-06-06 20:42:01 -07:00
Satoshi Kataoka
91c8c4f3a7 am e08cfda1: am 5a8d2fd1: Merge "Cache UserHistoryDictionary for each language" into jb-dev
* commit 'e08cfda1ebea693c56681816076c419f23c51076':
  Cache UserHistoryDictionary for each language
2012-06-06 10:48:46 -07:00