Since some variables with module LatinIME are defined but not used,
when compiled with build combination "sdk_pc_x86_64-userdebug" and
build command "mmm packages/inputmethods/LatinIME", the following
code lines will be reported that "variable 'XXX' set but not used".
(should be similar for all the other build combinations)
Repeated 10 times for each:
terminal_position_lookup_table.cpp:74:9 removedEntryCount
terminal_position_lookup_table.cpp:85:9 removedEntryCount
proximity_info_state_utils.cpp:493:9 tempTime
trie_map.cpp:56:9 unusedRegionSize
suggestion_results.cpp💯9 index
Repeated 80+ times:
proximity_info_utils.h:75:25 proximityChar
With this patch we are removing some of the unused variables and
putting the C++ 17 attribute [[maybe_unused]] to the others which
are used for logging. Then all the related build warnings have been
eliminated.
Test: mmm packages/inputmethods/LatinIME, presubmit check.
Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
Signed-off-by: Jing Mike <jingyangliu@eswincomputing.com>
This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:
BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower
See https://errorprone.info/bugpatterns for more
information on the checks.
Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: I454a105ae82484a2d19aff1808e8d9dd55ba64f4
am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea3848 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832
Change-Id: Ifc14b063977916d54bec38aa1d4f7f09bbe9d401
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea3848 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832
Change-Id: I35d476cbc57a934f0ba08a3ef203a1ec42ad7cd5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea3848 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832
Change-Id: I0aa5940a87d0a9cf5eb40d8d3841f0d0e6a7c310
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea3848 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832
Change-Id: I210262f2fe9ad726ae1c4c9a832ec6db5fd76a80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea3848 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832
Change-Id: I2c79acfa20a9200db266fd982b142905ec8cf0b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea3848 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832
Change-Id: Ifa4bae36305d050c1a6b5a569ad471f85a9d51d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
The ArrayEquals, ArrayHashCode, ArrayToString, and
ArraysAsListPrimitiveArray errorprone findings were
demoted from errors to warnings. Fix existing
occurrences of them so they can be made errors again.
Bug: 242630963
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: I689397a7196277de3fd301836e72f7555e2036cb
Bug: 228766370
Test: manual by using EditorTextVariations tool
1) make and install EditTextVariations
2) Enable "Settings > Display over other apps" for
EditTextVariations
3) Launch EditTextVariations from all apps
4) Menu -> Show IME focuable overlay
5) Go to home screen by gesture or pressing home key
6) Launch any app (e.g. Chrome) and tap the editor
7) Expect IME can show up
Change-Id: Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07
Remove the showDictionaryAvailableNotification
method since there is no module use it.
Bug: 209479751
Test: presubmit
Change-Id: I4c88b4a2d0cb36761d9102ce35260f93303625d9
