Commit Graph

30231 Commits

Author SHA1 Message Date
Keisuke Kuroyanagi
3339224813 Merge "Use nullptr instead of 0 for pointers." 2014-03-07 03:56:56 +00:00
Ken Wakasa
ce2ac1c835 Merge "Revert "Use std::min() and std::max()"" 2014-03-07 02:37:05 +00:00
Ken Wakasa
f63000abea Revert "Use std::min() and std::max()"
This somehow breaks TRT.

bug: 13350753

This reverts commit cf612a3abf.

Change-Id: I812f067e7cc8106b054527732dc6fe4efd7cc0fe
2014-03-07 02:30:18 +00:00
Keisuke Kuroyanagi
6c7ebc4023 Use nullptr instead of 0 for pointers.
Change-Id: Ic9425de07b896f940ca11c51968c637ebb897514
2014-03-07 10:04:44 +09:00
Baligh Uddin
1df1f56ec5 Merge "Import translations. DO NOT MERGE" 2014-03-06 21:14:52 +00:00
Ken Wakasa
34c653204c Merge "Use std::min() and std::max()" 2014-03-06 15:08:14 +00:00
Ken Wakasa
c290888461 Fix Mac SDK build
Temporary fix.

Change-Id: I79c8c31e7b07776a048a16918008a942261e1115
2014-03-06 23:41:23 +09:00
Ken Wakasa
cf612a3abf Use std::min() and std::max()
Change-Id: I2992fa16692ace2a6febedc4393812faf763638f
2014-03-06 23:19:54 +09:00
Tadashi G. Takaoka
eba0af1237 Merge "Add ExpectedKeyboardBuilder for testing keyboard layouts" 2014-03-06 12:34:49 +00:00
Yohei Yukawa
72c362985c Use C++11 deleted functions to implement DISALLOW_ macros
With C++ deleted functions, compilers can generate more
descriptive error messages when we are doing something disallowed.

Change-Id: I48d23e5eced545732558e56f5ff9ff70c95a6ff0
2014-03-06 20:48:43 +09:00
Ken Wakasa
ca0a0da864 Switch to C++11
Change-Id: Ib2970327c36422d7b11103d52ba7e9e52db5554f
2014-03-06 20:32:20 +09:00
Tadashi G. Takaoka
f7c84f35c7 Add ExpectedKeyboardBuilder for testing keyboard layouts
Bug: 13017434
Change-Id: I77ea2a60b1f3adf061689c68971d136ea5cf595e
2014-03-06 19:32:43 +09:00
Tadashi G. Takaoka
51523c3bc4 Merge "Add ExpectedKey for testing keyboard layouts" 2014-03-06 10:25:31 +00:00
Keisuke Kuroyanagi
de42f3f287 Merge "Fix: Bug of I39e905b6ddfc8d3." 2014-03-06 09:44:52 +00:00
Keisuke Kuroyanagi
9fd50e34a8 Fix: Bug of I39e905b6ddfc8d3.
primaryKey have to be the first elemnet of the proximities.

Bug: 13315755
Change-Id: I6c94408a2ef2750fa85ff12b93bed8b8d874717e
2014-03-06 18:25:15 +09:00
Jean Chalard
3892991b80 Merge "[IL124] Remove the KeyboardSwitcher arg to onCodeInput" 2014-03-06 09:15:26 +00:00
Tadashi G. Takaoka
c39c912a33 Add ExpectedKey for testing keyboard layouts
Bug: 13017434
Change-Id: I1c3b2c9cd1b86bdd782fc522b83380ec112f863b
2014-03-06 18:13:28 +09:00
Jean Chalard
4da06b9a19 Merge "Correctly update the suggestion strip on non-resumable word" 2014-03-06 08:54:44 +00:00
Keisuke Kuroyanagi
2c7e97dcdd Merge "Create suggest/core/result directory." 2014-03-06 07:32:19 +00:00
Keisuke Kuroyanagi
d93eb680c4 Merge "Use BinaryDictionaryUtils to read dictionary header." 2014-03-06 07:32:07 +00:00
Keisuke Kuroyanagi
fb1588dd3c Create suggest/core/result directory.
Bug: 8187060
Bug: 13333066
Change-Id: I185c93bd4542d997be101b61561a00d69111c00d
2014-03-06 14:35:47 +09:00
Jean Chalard
a1bf550294 [IL124] Remove the KeyboardSwitcher arg to onCodeInput
Bug: 8636060
Change-Id: I29ce4c82ea880a937b1c9e5daf494fcdbbdd1336
2014-03-06 14:20:41 +09:00
Jean Chalard
db38d5cf63 [IL123] Put the settings values inside the transaction
A transaction should always operate with a consistent set
of settings. It's better to have it reference them than to
always pass them along.

Bug: 8636060
Change-Id: I3c642dfea6be30712fc6cbb279c64f3185895791
2014-03-06 14:20:37 +09:00
Jean Chalard
5054530934 Merge "[IL122] Put the code, x and y in the transaction" 2014-03-06 03:55:00 +00:00
Jean Chalard
29881854bc [IL122] Put the code, x and y in the transaction
Bug: 8636060
Change-Id: Icdf87995dedec410b54c306e8d312ba7ec25cea6
2014-03-06 12:50:07 +09:00
Tadashi G. Takaoka
dbe531efa8 Merge "Remove unused text resource keylabel_for_east_slavic_row1_12" 2014-03-06 02:47:06 +00:00
Baligh Uddin
0b3f8935b5 Import translations. DO NOT MERGE
Change-Id: I7a730021b1c38c8ef7aa62b567a68a7cc478e516
Auto-generated-cl: translation import
2014-03-05 17:17:49 -08:00
Keisuke Kuroyanagi
de36b47d29 Use BinaryDictionaryUtils to read dictionary header.
Bug: 8187060
Bug:13035567
Change-Id: I90a5e0665c367f5a1bd786f4babf0d03e79e68fa
2014-03-05 19:42:53 +09:00
Keisuke Kuroyanagi
a84f7848d8 Merge "Fix: The top left key is a proximity of nonexistent keys." 2014-03-05 10:27:27 +00:00
Keisuke Kuroyanagi
274eae95ba Merge "Separate utility methods from BinaryDictionary." 2014-03-05 10:07:33 +00:00
Keisuke Kuroyanagi
6501255111 Fix: The top left key is a proximity of nonexistent keys.
Bug: 13315755
Change-Id: I39e905b6ddfc8d3510c408a3bea853390a75d088
2014-03-05 19:06:18 +09:00
Jean Chalard
c6e200ef3a Correctly update the suggestion strip on non-resumable word
Bug: 13303965
Change-Id: Iedc5d38f70af76fbebb99e59a0d17c1e226c810d
2014-03-05 18:47:41 +09:00
Keisuke Kuroyanagi
e784148ae6 Separate utility methods from BinaryDictionary.
Bug: 8187060
Change-Id: Ice2984e332b7bd3bb17174aefc80b5635b72fc50
2014-03-05 18:19:34 +09:00
Jean Chalard
4f6ce0df0b Merge "[IL121] Introduce InputTransaction" 2014-03-05 08:41:30 +00:00
Keisuke Kuroyanagi
287861c04b Merge "Separate utility methods from BinaryDictionary in native code." 2014-03-05 08:09:18 +00:00
Jean Chalard
7b905c40e9 [IL121] Introduce InputTransaction
We probably can't put this off any longer

Bug: 8636060
Change-Id: I1e5d3cf62d719f4d064ced3282bebf2e822f6baa
2014-03-05 17:04:10 +09:00
Keisuke Kuroyanagi
9e51c6c0c6 Separate utility methods from BinaryDictionary in native code.
Bug: 8187060
Change-Id: I099de557d2aaee95c6b809450108139550e9b0aa
2014-03-05 12:49:04 +09:00
Baligh Uddin
25d912df58 Merge "Import translations. DO NOT MERGE" 2014-03-04 17:24:35 +00:00
Tadashi G. Takaoka
8204078a84 Merge "Remove unused MoreKeysPanel argument from Controller interface" 2014-03-04 10:53:23 +00:00
Tadashi G. Takaoka
11eb0f9c14 Merge "Add action key label/icon tests" 2014-03-04 10:53:13 +00:00
Jean Chalard
151761a276 [IL120] Cleanup
Remove useless arguments, local vars, make stuff private

Change-Id: I7cc6c19e9c1703304d593e02be31eb9569cc7b4e
2014-03-04 17:52:14 +09:00
Jean Chalard
fb28935f82 [IL119] Make fields private.
Change-Id: Ia84d3e5a102e1056e3d7467be07df89390f17617
2014-03-04 17:52:14 +09:00
Jean Chalard
0e489d1ba3 [IL118] Factorize a method
If we can't get the right locale from the subtype switcher, we
should fallback in all cases.

Change-Id: I46a53a67927a793d9d3592a996a5a4392a36c6ff
2014-03-04 17:52:14 +09:00
Jean Chalard
129ca9e7eb [IL117] Simplification
Change-Id: Id4d4f30ecdc80dd59543f90fe2525f4bcc5afb9d
2014-03-04 17:52:11 +09:00
Tadashi G. Takaoka
4309b83ea9 Remove unused text resource keylabel_for_east_slavic_row1_12
The text resource used in 10 inch tablet layout.

This change also corrects {keylabel|more_keys}_for_east_slavic_row2_1
to _row2_2.

Change-Id: I60d69af22f97c008449b8dccc7c84ae6a05fe0d8
2014-03-04 17:12:31 +09:00
Jean Chalard
cf12210757 Merge "[IL116] Inline a method" 2014-03-04 07:48:02 +00:00
Jean Chalard
1940f26edb Merge "[IL115] Cleanup continues" 2014-03-04 07:46:11 +00:00
Tadashi G. Takaoka
1f215a58c9 Remove unused MoreKeysPanel argument from Controller interface
Bug: 13204690
Change-Id: Ife438e78d9bbbf796df20f95c2da7a4d50e5a035
2014-03-04 16:05:15 +09:00
Tadashi G. Takaoka
c451b4dee8 Merge "Separate flaky unit test from KeyboardLayoutSetTestsBase" 2014-03-04 06:57:31 +00:00
Tadashi G. Takaoka
3da9e4ade0 Add action key label/icon tests
Bug: 13017434
Change-Id: Ib04b377f4f4f9081573ef341f15b4b444ce7260c
2014-03-04 15:42:59 +09:00