Jean Chalard
01d47b8096
Fix a logic flaw.
...
This test is seriously wrong : although we do have a method that
does exactly the right thing, this looks at a very specific, unrelated
variable state in hope it happens to be set only in the relevant
cases by the play of logic.
I don't think this changes anything concretely, as the assumption
was probably true in the practice ; still, this code is very hard to
read and prone to unexpected breakage.
Change-Id: I77ab576f90762429fcc752df31ed30e1c81871dc
2012-11-09 19:16:37 +09:00
Ken Wakasa
710d06cea9
Suppress dictionary pack support when IS_EXPERIMENTAL is true
...
Change-Id: If8813cb989c1fa8744a3bf36e8514ced3c8f46a3
2012-11-09 15:03:31 +09:00
Ken Wakasa
43f579e9f6
am 4eef5101: am aa5d6fe0: am 9cc22c45: am 5d2556b9: Reset the IME if requested by the app.
...
* commit '4eef51016adc4e103fa65d944a0ab31527ddced8':
Reset the IME if requested by the app.
2012-11-08 06:22:02 -08:00
Ken Wakasa
5d2556b932
Reset the IME if requested by the app.
...
Specifically, reset the KeyboardState to the main Alphabet layout in
LatinIME.onStartInputViewInternal() if a keyboard layout set doesn't get
reloaded in the method.
Please note TextView.setText() calls up resetInput(), then the IME should
reset with it.
bug: 7482086
Note that bug: 6851364 needs to be revisited.
Change-Id: I5d448c10963d3dd952dd13cb587085ec7b014e69
2012-11-07 01:09:26 +09:00
Tadashi G. Takaoka
24ab8055aa
Move isInvalidCordinates() method to Constants class
...
Change-Id: Iad1464c299ad6055af1db1ff7978e5cd9a14750f
2012-11-01 13:12:58 +09:00
Tadashi G. Takaoka
c7318bbc0b
Fix possible NPE
...
Bug: 7398904
Change-Id: I6b7aba7a9bf52ca494cb4390b19525c98790bd49
2012-10-29 18:40:37 +09:00
Tadashi G. Takaoka
240871ecaf
Move code point constants from Keyboard to Constants class
...
Change-Id: Iee01d4d2b916d0b584531104ac865ae6e6370a3d
2012-10-29 16:04:20 +09:00
Satoshi Kataoka
6067b9e1bd
am ef5f88f3: am 5e118c4c: am 60dea36d: Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
...
* commit 'ef5f88f33e432284c958fafe18f891a10f77e1f9':
Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
2012-10-25 19:31:27 -07:00
Satoshi Kataoka
60dea36daf
Assuming that NO_EXTRACT_UI mode is NO_FULSCREEN
...
Bug: 7393485
Bug: 7272829
Change-Id: I873e8d99486c734e76484526631a90fc55e91c86
2012-10-25 20:00:46 +09:00
Jean Chalard
751f3dc0e1
am 6fe6f38d: am d39e6435: am f960eb18: Don\'t put spaces after characters that don\'t take one
...
* commit '6fe6f38d8af09b24e40a6e01eae919820cd04c16':
Don't put spaces after characters that don't take one
2012-10-22 21:46:43 -07:00
Jean Chalard
f960eb186d
Don't put spaces after characters that don't take one
...
Bug: 7393639
Change-Id: I1245a7b5077e554642838d6856ce269ca7f91988
2012-10-23 12:28:28 +09:00
Tadashi G. Takaoka
7f77aed507
Merge "Replace useless CharSequence to String"
2012-10-22 14:27:35 -07:00
Tadashi G. Takaoka
15f6d4ae34
Add @UsedForTesting and @ExternallyReferenced annotations
...
Bug: 7268357
Change-Id: I0b7e0c19f04af9ae30874d0a4c26ad81bc80be8c
2012-10-22 11:18:43 -07:00
Tadashi G. Takaoka
bc464e2952
Replace useless CharSequence to String
...
Change-Id: Idc478f901185ee1b4912acc82d0cbc54fee4e991
2012-10-22 11:03:28 -07:00
Tadashi G. Takaoka
8e360c68f1
Move AudioAndHapticFeedbackManager from LatinIME to KeyboardSwitcher
...
Bug: 7313372
Change-Id: I9bd3275f57ed3f5c2c4a95768443af505513ee97
2012-10-17 19:39:16 -07:00
Jean Chalard
c5dc32ac59
am b37e87e7: am 63b3fc0d: am 15142588: Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev
...
* commit 'b37e87e7d50725f20a6b2f8484fc25cc7db3134f':
Have "no whitespace before cursor" upon gesture trigger phantom space
2012-10-16 18:12:50 -07:00
Jean Chalard
1514258824
Merge "Have "no whitespace before cursor" upon gesture trigger phantom space" into jb-mr1-dev
2012-10-16 18:06:11 -07:00
Jean Chalard
e91d495c53
Have "no whitespace before cursor" upon gesture trigger phantom space
...
Bug: 7359291
Bug: 7357758
Bug: 7197651
Change-Id: Ia805a87e922739ae0a06978a3bf00d91c94b6c51
2012-10-17 09:36:07 +09:00
Jean Chalard
fa3d984d1b
am 60211f0d: am 2631fe4c: am 6686e63f: Honor automatic shift turned off for gestures
...
* commit '60211f0d250ca931788d32d5a69c880f75ef7d49':
Honor automatic shift turned off for gestures
2012-10-16 17:28:18 -07:00
Jean Chalard
6686e63f21
Honor automatic shift turned off for gestures
...
Bug: 7354129
Change-Id: Ia02336e8cea2f04b629edbe74b7815cce0d7fad6
2012-10-17 05:41:06 +09:00
Ken Wakasa
fc62882591
Fix a small typo
...
Change-Id: I813d97b9453f8aa7aae99bd165336b1e5a81dc6a
2012-10-07 12:05:23 +09:00
Tadashi G. Takaoka
792980d4aa
Avoid calling switchToLastInputMethod when other IMEs are in effect (DO NOT MERGE)
...
Bug: 7299050
Change-Id: Ife6721a5fcbc4872bd36ffd8a8b81b04d73aebec
2012-10-06 19:01:36 +09:00
Tadashi G. Takaoka
c6ff7c42d9
Add SuggestedWords.isEmpty() method
...
Change-Id: I0fcb104a6a81aee4b99f5ee848eba7495630dc7d
2012-10-03 15:09:10 +09:00
Tadashi G. Takaoka
5f5f7825e7
am 4d009dbc: am ace7d128: am d445b56c: Fix possible NPE caused while monkey test
...
* commit '4d009dbc514cd77eb22e4162e4ae7ea852e1b77e':
Fix possible NPE caused while monkey test
2012-10-02 22:44:57 -07:00
Tadashi G. Takaoka
d445b56ce1
Fix possible NPE caused while monkey test
...
Bug: 7269036
Change-Id: I9054b33ad3c8996cac3ee5f0e9c01ba8ceea4971
2012-10-03 14:33:52 +09:00
Tadashi G. Takaoka
aec5cc8476
Avoid calling switchToLastInputMethod when other IMEs are in effect
...
Bug: 7268389
Change-Id: I4d960cbf063002b4dc0ea813c966366b56c0346d
2012-10-02 17:29:15 +09:00
Jean Chalard
574b80aace
Remove debug prints.
...
Bug: 7226098
Change-Id: Ibacb740022a6af56c9d555d6797dd402a89f6ca4
2012-10-01 17:03:15 +09:00
Tadashi G. Takaoka
58fe5a421f
Fix gesture detection algorithm
...
This change also
* Introduces adaptive gesture detecting threshold for time domain in addition to length domain.
* Tunes the parameters for detecting gesture after fast typing.
* Fixes a bug in dismissing gesture floating preview text.
* Cleanup debug messages
Bug: 7218902
Change-Id: Iafccd872c6efe0c3b5ae65fa40b04c80d9f139c7
2012-09-28 22:47:55 +09:00
Tadashi G. Takaoka
a28a05e971
Cleanup: Make some classes as final
...
Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e
2012-09-27 19:03:30 +09:00
Jean Chalard
0eef4b1e6f
Merge "Add suggestion span upon starting a gesture." into jb-mr1-dev
2012-09-24 04:30:32 -07:00
Jean Chalard
6a58bb7ac9
Add suggestion span upon starting a gesture.
...
Bug: 7196761
Change-Id: If60cb809b205159ced1887f94b7caf9775fcf3bb
2012-09-24 20:25:46 +09:00
Jean Chalard
88985bfa2e
Merge "Fix a bug where the cursor pos wouldn't be tracked correctly" into jb-mr1-dev
2012-09-24 03:41:48 -07:00
Jean Chalard
72c5d32888
Fix a bug where the cursor pos wouldn't be tracked correctly
...
This would cause
Bug: 7208199
Change-Id: I8474985bfe349e1530b27bc98842937627bbe4e0
2012-09-24 19:33:42 +09:00
Jean Chalard
6efe788494
Set punctuation suggestions at start if activated
...
Bug: 7218468
Change-Id: I9f8c1f13dc26cedb95b65279a34a825021dfa72a
2012-09-24 17:27:03 +09:00
Jean Chalard
fff8613df0
Fix a race condition with shift
...
Bug: 7062092
Change-Id: Ie1984673e9ffc9291d9650ec38ce99031ad93585
2012-09-24 15:07:52 +09:00
Jean Chalard
b4e74cfc87
Auto correct on gesture when typed word is 1 char long
...
Bug: 7178462
Change-Id: I779d8ee4a957a9d1fdcc80d33257a98965dec7b8
2012-09-20 16:14:16 +09:00
Satoshi Kataoka
87cecf7db6
Log for geometric input
...
Change-Id: Ia0f0e38086b0be70cf2d04fc6fae48358f16e74f
2012-09-19 17:45:27 +09:00
Jean Chalard
e4783f95b2
Mark 2 resolved TODOS as such (A14)
...
Change-Id: Ifbb731f5c825675436d079db4ffbae657d71f8da
2012-09-18 18:49:17 +09:00
Jean Chalard
5822323514
Remove useless code (A12)
...
All this code is done inside the StringUtils or RichInputConnection
classes, where it's more logical. Since the IPC call is entirely
gone now, it's no use having these guards inside Latin IME.
Change-Id: Id324567e7458aed12b6f21d7114be3bd39725f15
2012-09-18 16:16:33 +09:00
Jean Chalard
90a9127244
Take space state into account for caps (A11)
...
Bug: 6950087
Change-Id: I8a1bca24db64b4dd54db8ac74d90cf43cbdddab6
2012-09-18 16:16:28 +09:00
Jean Chalard
252da38fcd
Take locale into account for caps (A10)
...
Bug: 4967874
Change-Id: Ic7ce7b2de088308fa00865c81246c84c605db1e5
2012-09-14 19:42:05 +09:00
Jean Chalard
a3f06baa57
Merge "Do not auto-correct upon starting a gesture." into jb-mr1-dev
2012-09-14 03:11:51 -07:00
Jean Chalard
b29efecd26
Merge "Fix a bug with open parens and some other chars" into jb-mr1-dev
2012-09-14 02:30:36 -07:00
Jean Chalard
7e4ad33a65
Fix a bug with open parens and some other chars
...
A space would be inserted after an open parenthesis if
it's typed after a manual pick.
Bug: 7167687
Change-Id: Ic49d09c34747117ccfbdbb8c66f634d88d4a45b0
2012-09-14 18:23:35 +09:00
Tadashi G. Takaoka
f035649cb6
Asynchronously look up dictionary for gesture input
...
Bug: 7149248
Change-Id: Icba2db73508b89a85828ae9e196ab618e5e6c280
2012-09-14 02:12:11 -07:00
Jean Chalard
eda096538b
Do not auto-correct upon starting a gesture.
...
We decided to revert this UI decision after negative feedback.
Indeed, if you use to gesture but tap just one word, chances
are it's because you know you do NOT want a dictionary word.
Bug: 6965241
Change-Id: I85fdfab3c1cf1d3c0fd3e95908e01bdf56bccbba
2012-09-14 17:52:54 +09:00
Jean Chalard
2427f578c8
Merge "Import TextUtils.getCapsMode to fix it internally (A1)" into jb-mr1-dev
2012-09-13 02:57:35 -07:00
Jean Chalard
9d1c73ffd8
Import TextUtils.getCapsMode to fix it internally (A1)
...
This should have on effect at all on behavior,
except an increase in performance.
Bug: 4967874
Bug: 6950087
Change-Id: Ie2b51efefe84ca767f5dc8e3b80bfef7e1faab3d
2012-09-13 17:46:39 +09:00
Jean Chalard
5ed88457bf
Make onUpdateSelection much more resilient to race conditions.
...
This is pretty much as strong as it gets. It should be
impossible to get false positives and nearly impossible to
get true negatives with this new code.
Bug: 6981089
Change-Id: Ia32ab62f89c5943f0be169b979abab652e67bf5b
2012-09-13 17:35:26 +09:00
Jean Chalard
28d765ed90
Make Latin IME aware of its surrounding text.
...
This is a preparatory change for
Bug: 4967874
Bug: 6617760
Bug: 6950087
Change-Id: I3abf8e45c0d02c42491421f108370220134b9602
2012-09-12 17:54:16 +09:00