Since some variables with module LatinIME are defined but not used,
when compiled with build combination "sdk_pc_x86_64-userdebug" and
build command "mmm packages/inputmethods/LatinIME", the following
code lines will be reported that "variable 'XXX' set but not used".
(should be similar for all the other build combinations)
Repeated 10 times for each:
terminal_position_lookup_table.cpp:74:9 removedEntryCount
terminal_position_lookup_table.cpp:85:9 removedEntryCount
proximity_info_state_utils.cpp:493:9 tempTime
trie_map.cpp:56:9 unusedRegionSize
suggestion_results.cpp💯9 index
Repeated 80+ times:
proximity_info_utils.h:75:25 proximityChar
With this patch we are removing some of the unused variables and
putting the C++ 17 attribute [[maybe_unused]] to the others which
are used for logging. Then all the related build warnings have been
eliminated.
Test: mmm packages/inputmethods/LatinIME, presubmit check.
Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
Signed-off-by: Jing Mike <jingyangliu@eswincomputing.com>
This will ensure that the target stays green.
Note: we will clean up the explicit unit_tests:true once cc_test default is changed.
Change-Id: I5153ca918e94b370b1f08289118877d209385ba2
Test: presubmit
Bug: 180014759
Preparation for removing implicit include paths for jni.h from soong.
Bug: 152482542
Test: lunch aosp_x86_64 && m checkbuild
Change-Id: Ib36e679819a3309ccbf12fd592309b16c8bbd6c8
This app is frequently overriden by proprietary apps
on shipping devices, so move it to /product along with
its jni library.
Bug: 122353713
Test: launch keyboard on aosp_arm64 emulator
Change-Id: Ied8c1e6133b67e28da76b0e48254e2e2e0ed15bf
See build/soong/README.md for more information.
Test: cd packages/inputmethods/LatinIME; mma
Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
Merged-In: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
This CL addresses compiler warnings when building libjni_latinime.so
with NDK from Android Studio.
There should be no behavior change.
Bug: 110741422
Bug: 110757803
Test: tapas LatinIME LatinIMETests arm64 userdebug && make -j
Change-Id: Icc711dd46511a167b1fd90028552def5b2f9941f
Host-side C++ test in LatinIME is no longer actively used and is
actually not compatible with Android Studio build.
Let's just remove this for now.
Bug: 13754552
Bug: 110741422
Test: compile
Change-Id: I3e81285fe559022e1a296051036e74d2f2afbf9c
