A mirror for futokb (https://gitlab.futo.org/keyboard)
Go to file
Ken Wakasa b044047227 mExpectingUpdateSelection was out of sync when nothing to delete.
cherripick of I9c6a948331726a821bd3ccec9c1d02dec2c4703a
(forward cherrypicking this because the automerger is stuck now.)

This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.

1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace

The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.

bug: 11181913
Change-Id: I1cbf444d8d105416e7de75c16d80b3797f470495
2013-10-15 14:05:34 +09:00
dictionaries Update dictionaries 2013-10-08 10:34:56 +00:00
java mExpectingUpdateSelection was out of sync when nothing to delete. 2013-10-15 14:05:34 +09:00
native Fix offdevice test build. 2013-10-08 16:05:42 +09:00
tests Fix unit test for If8c94ef91ed58bb5028f51be7c8d9beb677436a4 2013-10-11 16:52:12 +09:00
tools Revert "Add Swiss French and German keyboard layouts." 2013-10-10 02:05:50 +00:00
Android.mk Build native subdirectories first 2013-01-28 20:07:31 -08:00
CleanSpec.mk Pass the touch position correction data to native. 2011-09-29 17:00:49 +09:00