am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea3848 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832
Change-Id: I35d476cbc57a934f0ba08a3ef203a1ec42ad7cd5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea3848 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832
Change-Id: I210262f2fe9ad726ae1c4c9a832ec6db5fd76a80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea3848 is already in history
Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832
Change-Id: Ifa4bae36305d050c1a6b5a569ad471f85a9d51d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
Bug: 228766370
Test: manual by using EditorTextVariations tool
1) make and install EditTextVariations
2) Enable "Settings > Display over other apps" for
EditTextVariations
3) Launch EditTextVariations from all apps
4) Menu -> Show IME focuable overlay
5) Go to home screen by gesture or pressing home key
6) Launch any app (e.g. Chrome) and tap the editor
7) Expect IME can show up
Change-Id: Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07
Remove the showDictionaryAvailableNotification
method since there is no module use it.
Bug: 209479751
Test: presubmit
Change-Id: I4c88b4a2d0cb36761d9102ce35260f93303625d9
From T, apps need POST_NOTIFICATION permission
to send the notification.
-. Add the permission into Manifest.
-. Request runtime permission when it's needed.
Bug: 209479751
Test: Manual test as following steps:
1. Open EditTextVariations at T device.
2. Tap direct reply to send notification.
3. Verify the permission dialog show up.
4. Send the notification if permission granted.
Change-Id: Iadae00f635ee556d1d1de9abbb9da0498b4070f1
The keyboard key-press haptic feedback should follow the user
settings for "Touch feedback".
Bug: 185351540
Test: manual
Change-Id: I718d3bf15b1ef841a869a898038d0eca1eca78f0
With CL[1],[2] to migrate InputMethodService as the subclass of the new
introduced class WindowProviderService in S_V2, IME context resources
can be managed by associating the window container of IME window when
its display/window configuration changed.
So we can get rid of createDisplayContext logic from S_V2 with gated
by SDK version and refining the method of get IME context with
documentation to make it clear.
[1]: Ie565e30ed5dd3f2cfe27355a6dded76dc3adc14b
[2]: I64a1614f32d097785915f6105b1813a929e0fe32
Bug: 213118079
Bug: 133825283
Test: manual with below steps
1) adb install -r EditTextVariations.apk
2) tapas LatinIME
3) make
4) adb install -r out/target/product/generic/system/app/LatinIME/\
LatinIME.apk
5) adb shell ime enable com.android.inputmethod.latin/.LatinIME
6) adb shell ime set com.android.inputmethod.latin/.LatinIME
5) Enable screen auto-rotation
7) Launch EditTextVariations from launcher's shortcut
8) Tap the first EditText field to show IME
9) Rotate the device to the landscape mode
10) Expect the IME should not be shrunk
Change-Id: If2cc1c5bdb257a9c0af653fa7157cf781a90bf1d
As CL[1] introduces diplayContext to address
IME service context's Resources / DisplayMetrics update when
switching IME window to another display after onConfigurationChange.
In LatinIME#onInitializeInterface, we only update keyboard theme context
and displayContent when the displayId is changed, but overlooked even
the displayId is the same, the display context's resource configuration
might changed like the device orientation changd.
It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height
fraction value when rotating to landcape because the context resources
didn't get updated.
Add a check to update keyboard theme context when the current display
configuation is changed accordingly.
[1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed
Fix: 186507147
Test: manual as issue steps
1) Turn on auto-rotate
2) Open Settings
3) Rotating the device to landscape mode
4) Tap “Search settings", verify if the soft-keyboard shown and the
size is expected.
Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
Merged-In: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
With this CL, versionCode, targetSdkVersion and minSdkVersion will be
bumped/set as follows:
versionCode: 28 -> 30
targetSdkVersion: 28 -> 30
minSdkVersion: 21
As far as we know, there should be no user-visible behavior change on
supported OS versions.
Fix: 189558760
Test: manually verified that LatinIME still is functional
Change-Id: I3a7deb452960b370f5290f3d1bac9c79fe935303
Merged-In: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
(cherry picked from commit 360052f3044eee612af1cbfcd1f2e202096e3541)